Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@PluginBuilder/Controllers/ApiController.cs`:
- Around line 224-226: The GetPluginStats anonymous endpoint in ApiController
(method GetPluginStats) lacks the public API rate limiting attribute; add the
[EnableRateLimiting(Policies.PublicApiRateLimit)] attribute to the
GetPluginStats action (above the method, alongside [AllowAnonymous] and
[HttpGet("plugins/{pluginSlug}/stats")]) so it uses the same PublicApiRateLimit
policy as other public read endpoints.
- Around line 217-218: The code is mapping snapshot Identifier into telemetry
Slug, which fragments per-plugin stats; change the projection that builds
pluginReports so PluginReport is constructed with the plugin's canonical slug
(e.g., p.Slug or the field used by download telemetry) instead of p.Identifier —
e.g., replace new PluginReport(p.Identifier, p.Version) with new
PluginReport(p.Slug ?? p.Identifier, p.Version) or, preferably, new
PluginReport(p.Slug, p.Version) to ensure telemetry Slug comes from the
download/telemetry slug field rather than the snapshot Identifier.
- Around line 217-221: The current code in ApiController builds pluginReports
and always calls telemetryService.RecordServerSnapshot even when pluginReports
is empty; change this by adding a guard: after building pluginReports (the
variable), check if pluginReports.Any() (or Count > 0) and only call
telemetryService.RecordServerSnapshot(remoteIp, userAgent, pluginReports,
xOriginalFor, xForwardedFor) when non-empty, otherwise skip the call and still
return Ok(); this prevents sending empty telemetry that marks installs as
uninstalled.

In `@PluginBuilder/Services/TelemetryService.cs`:
- Around line 139-161: The uninstall SQL currently decrements install_count
(plugin_server_installs.install_count) which makes GetStats (method GetStats
returning PluginStats) undercount total installs; instead stop mutating
install_count on uninstall and introduce/maintain separate cumulative counters
(e.g., cumulative_installs and cumulative_uninstalls) or an events table for
installs/uninstalls; update the uninstall UPDATE that sets uninstalled_at to no
longer decrement install_count and to increment the cumulative_uninstalls
counter (or insert an uninstall event), and change the GetStats query to compute
TotalInstalls and TotalUninstalls from those cumulative columns/events while
deriving ActiveInstalls from COUNT(*) FILTER (WHERE uninstalled_at IS NULL)
(references: plugin_server_installs, install_count, uninstalled_at, GetStats,
PluginStats).
- Around line 88-131: The payload may contain duplicate plugin.Slug values
causing the upsert loop to attempt an INSERT twice and violate the (hashed_ip,
plugin_slug) PK; before computing reportedSlugs and iterating, deduplicate
pluginList by Slug using a case-insensitive grouping (so reportedSlugs and the
foreach use the deduped collection), then proceed with the existing
existingBySlug/foreach logic referencing pluginList and plugin.Slug; this
ensures each slug is processed exactly once and avoids duplicate INSERT
attempts.
- Around line 218-223: The current logic in TelemetryService that trims
forwarded IPs (the raw variable before IPAddress.TryParse) incorrectly splits
plain IPv6 addresses; update the parsing so bracketed addresses are handled by
extracting text between '[' and ']' when raw.Contains("]:")/raw.Contains(']'),
and only strip a trailing port by splitting on ':' when the string is an IPv4
with a port (detect by presence of '.' or by there being exactly one ':'),
otherwise leave raw intact for IPv6 (multiple ':'s). Modify the block that
currently uses raw.Contains(':') && !raw.Contains('.') to instead detect
IPv4-with-port (e.g., raw.Contains('.') || raw.Count(c=>c==':')==1) before
splitting so IPv6 addresses reach IPAddress.TryParse unchanged.